There should be a few more example involving properties, local variables, parameters, functions, tuples, optional bindings, ...

Examples added for all the use cases

What about:

var a = 1
if let a = b {}

var i = 1
for i in list {}

struct S {
  var a = 1
  var b: Int {
    let a = 2
    return a
  }
}

var a = 1
func a(a: Int) {} // Should we trigger for the function name and/or the parameter (optionally)?

Thanks for highlighting, i have added additional triggering examples, expanding the triggering examples

var a = 1
func a(a: Int) {} // Should we trigger for the function name and/or the parameter (optionally)?

Triggering for parameters is optional, but the current behavior (not triggering) is standard and user-friendly. If you want to add an option to control this, I can add a configuration flag (e.g., ignoreParameters: true/false).

Thanks for highlighting, i have added additional triggering examples, expanding the triggering examples

Sure? I can't find them.

Triggering for parameters is optional, but the current behavior (not triggering) is standard and user-friendly. If you want to add an option to control this, I can add a configuration flag (e.g., ignoreParameters: true/false).

I'd prefer an option for that as I think some would like that. However, I leave it open to you to implement it or ignore it for now. In the latter case, this can be a follow-up.

Thanks for highlighting, i have added additional triggering examples, expanding the triggering examples

Sure? I can't find them.

Apologies, didn't push it yet.

Triggering for parameters is optional, but the current behavior (not triggering) is standard and user-friendly. If you want to add an option to control this, I can add a configuration flag (e.g., ignoreParameters: true/false).

I'd prefer an option for that as I think some would like that. However, I leave it open to you to implement it or ignore it for now. In the latter case, this can be a follow-up.

Yes, i can look into this, will tag you once all the changes are pushed

Hi @SimplyDanny, I have updated the rules with configuration and also added relevent examples, so all changes are pushed now

I'm still missing

struct S {
  var a = 1
  var b: Int {
    let ↓a = 2
    return a
  }
}

And like if expressions, we can also have while let a = ... {}
and guard let a = ... else {}.

What about:

var a = 1
if let a = b {}

var i = 1
for i in list {}

struct S {
  var a = 1
  var b: Int {
    let a = 2
    return a
  }
}

var a = 1
func a(a: Int) {} // Should we trigger for the function name and/or the parameter (optionally)?

Rule should be opt-in.

I'm still missing

struct S {
  var a = 1
  var b: Int {
    let ↓a = 2
    return a
  }
}

And like if expressions, we can also have while let a = ... {}
and guard let a = ... else {}.

No test case fails if checkForBindingShadowing is used here. Is checkForShadowing really necessary? I actually doubt it. If it is, we need an example.

This test isn't needed. You already check the option in the rule's examples.

We might not need this anymore once #6589 is merged.